Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start moving lecacy scale hooks to plugin #10631

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Start moving lecacy scale hooks to plugin #10631

wants to merge 1 commit into from

Conversation

LeeLenaleee
Copy link
Collaborator

@LeeLenaleee LeeLenaleee commented Aug 25, 2022 •
edited
Loading

Resolves #10155

TODO:

@etimberg you added the breaking change to it but in its current form its not breaking right since it still calls the hooks like it used to or do you want to have the call (line 527) here also removed?

Chart.js/src/core/core.scale.js

Lines 525 to 528 in f957aad

_callHooks(name) {
this.chart.notifyPlugins(name, this.getContext());
call(this.options[name], [this]);
}

@LeeLenaleee LeeLenaleee added this to the Version 4.0 milestone Aug 25, 2022
@etimberg
Copy link
Member

Yeah, I had thought we could remove line 527 so that it only goes to plugins and avoids these option callbacks

@etimberg
Copy link
Member

etimberg commented Oct 1, 2022

@LeeLenaleee @kurkle do we still want this in v4? It's the last thing

@LeeLenaleee
Copy link
Collaborator Author

Every time I look at the test i can't seem to make them work so stopped looking at it, will give it another look Monday evening see if a fresh look sees what I did wrong and otherwise we can either skip it or someone else has to fix the test

@etimberg
Copy link
Member

I'm thinking we should skip this and move it to v5 at this point. Thoughts @LeeLenaleee @kurkle @dangreen ?

@LeeLenaleee
Copy link
Collaborator Author

Agree

1 similar comment
@dangreen
Copy link
Collaborator

Agree

@etimberg etimberg modified the milestones: Version 4.0, Version 5.0 Oct 10, 2022
@LeeLenaleee LeeLenaleee deleted the move-legacy-scale-hooks-to-plugin branch January 15, 2024 17:12
@LeeLenaleee LeeLenaleee restored the move-legacy-scale-hooks-to-plugin branch January 15, 2024 21:45
@LeeLenaleee LeeLenaleee reopened this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change type: enhancement
Projects
None yet
Milestone
Version 5.0.0
Development

Successfully merging this pull request may close these issues.

Convert Scale Legacy Callbacks to Plugin Hooks
3 participants
@LeeLenaleee @etimberg @dangreen